Add optional intensity parameter for surfaces #314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikolalysenko
force-pushed
the
surface-intensity
branch
from
12a4865 to
cb9a14e
Compare
mikolalysenko
force-pushed
the
surface-intensity
branch
from
cb9a14e to
00109fd
Compare
src/traces/surface/attributes.js
Outdated
| }, | ||
| zauto: colorscaleAttrs.zauto, | ||
| zmin: colorscaleAttrs.zmin, | ||
| zmax: colorscaleAttrs.zmax, |
There was a problem hiding this comment.
Ok, a couple things will need to happen here:
- rename
intensity->surfacecolor - add
cauto,cminandcmax(which will take up the role ofzauto,zminandzmaxrespectively) - move
zauto,zminandzmaxto the bottom of the attribute object in a_deprecatedblock (see example here) - add a backward-compatible block in
cleanData:
if(trace.type === 'surface') {
if(trace.zauto) trace.cauto = trace.zauto;
delete trace.zauto
/* and so on for 'zmin' and 'zmax'
}
| "zmin": 0, | ||
| "zmax": "50" | ||
| "cmin": 0, | ||
| "cmax": "50" |
There was a problem hiding this comment.
The old zmin and zmax attributes should still work.
|
closed in favour of #347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #308
Please note that this PR requires the following feature in gl-surface3d being merged:
gl-vis/gl-surface3d#6
To use the new intensity parameter for surface, you just pass in a
data_arrayparameter type calledintensityto the surface. The behavior is analogous to mesh3d traces.Example image:
CC @etpinard